From b6119e581e6ea9273b188463dc4529c30db140ba Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Tue, 6 Jul 2021 16:51:55 +0200 Subject: uhd: Replace Boost mutexes and locks with standard options This is a very mechanical task that could almost have been done with sed. Boost versions of mutexes and locks were removed, and replaced with std:: versions. The replacement tables are as follows: == Mutexes == - boost::mutex -> std::mutex - boost::recursive_mutex -> std::recursive_mutex Mutexes behave identically between Boost and std:: and have the same API. == Locks == C++11 has only two types of lock that we use/need in UHD: - std::lock_guard: Identical to boost::lock_guard - std::unique_lock: Identical to boost::unique_lock Boost also has boost::mutex::scoped_lock, which is a typedef for boost::unique_lock<>. However, we often have used scoped_lock where we meant to use lock_guard<>. The name is a bit misleading, "scoped lock" sounding a bit like an RAII mechanism. Therefore, some previous boost::mutex::scoped_lock are now std::lock_guard<>. std::unique_lock is required when doing more than RAII locking (i.e., unlocking, relocking, usage with condition variables, etc.). == Condition Variables == Condition variables were out of the scope of this lock/mutex change, but in UHD, we inconsistently use boost::condition vs. boost::condition_variable. The former is a templated version of the latter, and thus works fine with std::mutex'es. Therefore, some boost::condition_variable where changed to boost::condition. All locks and mutexes use `#include `. The corresponding Boost includes were removed. In some cases, this exposed issues with implicit Boost includes elsewhere. The missing explicit includes were added. --- host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp') diff --git a/host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp b/host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp index 116051216..a4f46fca6 100644 --- a/host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp +++ b/host/lib/usrp/usrp2/usrp2_fifo_ctrl.cpp @@ -12,9 +12,7 @@ #include #include #include //htonl -#include -#include -#include +#include using namespace uhd; using namespace uhd::transport; @@ -58,7 +56,7 @@ public: ******************************************************************/ void poke32(const wb_addr_type addr, const uint32_t data) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt((addr - SETTING_REGS_BASE) / 4, data, POKE32_CMD); @@ -67,7 +65,7 @@ public: uint32_t peek32(const wb_addr_type addr) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt((addr - READBACK_BASE) / 4, 0, PEEK32_CMD); @@ -92,7 +90,7 @@ public: ******************************************************************/ void init_spi(void) { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt(SPI_DIV, SPI_DIVIDER, POKE32_CMD); this->wait_for_ack(_seq_out - MAX_SEQS_OUT); @@ -106,7 +104,7 @@ public: size_t num_bits, bool readback) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); // load control word uint32_t ctrl_word = 0; @@ -145,7 +143,7 @@ public: ******************************************************************/ void set_time(const uhd::time_spec_t& time) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); _time = time; _use_time = _time != uhd::time_spec_t(0.0); if (_use_time) @@ -154,13 +152,13 @@ public: uhd::time_spec_t get_time() override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); return _time; } void set_tick_rate(const double rate) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); _tick_rate = rate; } @@ -234,7 +232,7 @@ private: } zero_copy_if::sptr _xport; - boost::mutex _mutex; + std::mutex _mutex; uint16_t _seq_out; uint16_t _seq_ack; uhd::time_spec_t _time; -- cgit v1.2.3