From 5ee6b828debbd60e03aff805bfd80e2030715a6f Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Tue, 31 Aug 2021 11:49:51 +0200 Subject: uhd: math: Replace wrap-frequency math with a single function In multiple places in the UHD code, we were doing the same calculation for a wrapped frequency (wrap it into the first Nyquist zone). This math was using boost::math, too. Instead of editing every instance, we create a new function, uhd::math::wrap_frequency(), and replace all of its separate implementations with this function. The new function also no longer relies on boost::math::sign. --- host/lib/usrp/usrp1/codec_ctrl.cpp | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) (limited to 'host/lib/usrp/usrp1/codec_ctrl.cpp') diff --git a/host/lib/usrp/usrp1/codec_ctrl.cpp b/host/lib/usrp/usrp1/codec_ctrl.cpp index 413caaf67..c5268b3c4 100644 --- a/host/lib/usrp/usrp1/codec_ctrl.cpp +++ b/host/lib/usrp/usrp1/codec_ctrl.cpp @@ -12,13 +12,13 @@ #include #include #include +#include #include #include -#include #include #include -#include #include +#include #include #include @@ -380,15 +380,10 @@ double usrp1_codec_ctrl_impl::fine_tune(double codec_rate, double target_freq) void usrp1_codec_ctrl_impl::set_duc_freq(double freq, double rate) { - double codec_rate = rate * 2; - - // correct for outside of rate (wrap around) - freq = std::fmod(freq, rate); - if (std::abs(freq) > rate / 2.0) - freq -= boost::math::sign(freq) * rate; - - double coarse_freq = coarse_tune(codec_rate, freq); - double fine_freq = fine_tune(codec_rate / 4, freq - coarse_freq); + const double codec_rate = rate * 2; + freq = uhd::math::wrap_frequency(freq, rate); + const double coarse_freq = coarse_tune(codec_rate, freq); + const double fine_freq = fine_tune(codec_rate / 4, freq - coarse_freq); UHD_LOGGER_DEBUG("USRP1") << "ad9862 tuning result:" << " requested: " << freq -- cgit v1.2.3