diff options
| -rw-r--r-- | host/docs/usrp_x3x0_config.rst | 7 | ||||
| -rw-r--r-- | host/lib/usrp/b200/b200_impl.cpp | 9 | ||||
| -rw-r--r-- | host/lib/usrp/b200/b200_impl.hpp | 11 | ||||
| -rw-r--r-- | host/lib/usrp/b200/b200_io_impl.cpp | 69 | ||||
| -rw-r--r-- | host/lib/usrp/multi_usrp.cpp | 51 | ||||
| -rw-r--r-- | host/lib/usrp/x300/x300_impl.cpp | 109 | ||||
| -rw-r--r-- | host/lib/usrp/x300/x300_impl.hpp | 43 | ||||
| -rw-r--r-- | host/lib/usrp/x300/x300_io_impl.cpp | 150 | ||||
| -rw-r--r-- | host/utils/uhd_cal_rx_iq_balance.cpp | 18 | ||||
| -rw-r--r-- | host/utils/uhd_cal_tx_dc_offset.cpp | 16 | ||||
| -rw-r--r-- | host/utils/uhd_cal_tx_iq_balance.cpp | 19 | ||||
| -rw-r--r-- | host/utils/usrp_cal_utils.hpp | 31 | 
12 files changed, 294 insertions, 239 deletions
| diff --git a/host/docs/usrp_x3x0_config.rst b/host/docs/usrp_x3x0_config.rst index 9cb000275..22ef8c595 100644 --- a/host/docs/usrp_x3x0_config.rst +++ b/host/docs/usrp_x3x0_config.rst @@ -69,19 +69,20 @@ Configuring the MTU  -------------------------------------  In order to achieve maximum performance, we recommend setting the MTU size to  9000 for 10 GigE and 1500 for 1 GigE. It is possible to use smaller MTUs, but this -can affect performance. With some NICs, setting the MTU too high can also cause issues, -though. To set the MTU to 9000, you can use the following command: +can affect performance. With some NICs, setting the MTU too high can also cause issues. +To set the MTU to 9000, you can use the following command:  ::      sudo ifconfig <interface> mtu 9000 # For 10 GigE +    sudo ifconfig <interface> mtu 1500 # For 1 GigE  Using these MTUs will set the frame sizes for UHD communication to 8000 and 1472,  respectively.  In some cases, specifying the frame size manually by adding the argument  "<send/recv>_frame_size=1472" can solve issues. Note that a frame size of 1472 will limit -the available sampling rate, although this is likely not a problem issue on 1 GigE. +the available sampling rate, although this is not a problem on 1 GigE.  Configuring the Firewall diff --git a/host/lib/usrp/b200/b200_impl.cpp b/host/lib/usrp/b200/b200_impl.cpp index 74e61143b..66df1f3bc 100644 --- a/host/lib/usrp/b200/b200_impl.cpp +++ b/host/lib/usrp/b200/b200_impl.cpp @@ -1,5 +1,5 @@  // -// Copyright 2012-2013 Ettus Research LLC +// Copyright 2012-2014 Ettus Research LLC  //  // This program is free software: you can redistribute it and/or modify  // it under the terms of the GNU General Public License as published by @@ -373,12 +373,15 @@ b200_impl::b200_impl(const device_addr_t &device_addr)      ////////////////////////////////////////////////////////////////////      // create frontend mapping      //////////////////////////////////////////////////////////////////// +    std::vector<size_t> default_map(2, 0); default_map[1] = 1; // Set this to A->0 B->1 even if there's only A +    _tree->create<std::vector<size_t> >(mb_path / "rx_chan_dsp_mapping").set(default_map); +    _tree->create<std::vector<size_t> >(mb_path / "tx_chan_dsp_mapping").set(default_map);      _tree->create<subdev_spec_t>(mb_path / "rx_subdev_spec")          .set(subdev_spec_t()) -        .subscribe(boost::bind(&b200_impl::update_rx_subdev_spec, this, _1)); +        .subscribe(boost::bind(&b200_impl::update_subdev_spec, this, "rx", _1));      _tree->create<subdev_spec_t>(mb_path / "tx_subdev_spec")          .set(subdev_spec_t()) -        .subscribe(boost::bind(&b200_impl::update_tx_subdev_spec, this, _1)); +        .subscribe(boost::bind(&b200_impl::update_subdev_spec, this, "tx", _1));      ////////////////////////////////////////////////////////////////////      // setup radio control diff --git a/host/lib/usrp/b200/b200_impl.hpp b/host/lib/usrp/b200/b200_impl.hpp index c88d14ad5..a370e54f9 100644 --- a/host/lib/usrp/b200/b200_impl.hpp +++ b/host/lib/usrp/b200/b200_impl.hpp @@ -127,8 +127,7 @@ private:      void set_mb_eeprom(const uhd::usrp::mboard_eeprom_t &);      void check_fw_compat(void);      void check_fpga_compat(void); -    void update_rx_subdev_spec(const uhd::usrp::subdev_spec_t &); -    void update_tx_subdev_spec(const uhd::usrp::subdev_spec_t &); +    void update_subdev_spec(const std::string &tx_rx, const uhd::usrp::subdev_spec_t &);      void update_time_source(const std::string &);      void update_clock_source(const std::string &);      void update_bandsel(const std::string& which, double freq); @@ -150,8 +149,12 @@ private:          bool ant_rx2;      };      std::vector<radio_perifs_t> _radio_perifs; -    void setup_radio(const size_t which_radio); -    void handle_overflow(const size_t index); + +    /*! \brief Setup the DSP chain for one radio front-end. +     * +     */ +    void setup_radio(const size_t radio_index); +    void handle_overflow(const size_t radio_index);      struct gpio_state {          boost::uint32_t  tx_bandsel_a, tx_bandsel_b, rx_bandsel_a, rx_bandsel_b, rx_bandsel_c, codec_arst, mimo, ref_sel; diff --git a/host/lib/usrp/b200/b200_io_impl.cpp b/host/lib/usrp/b200/b200_io_impl.cpp index 4768aa37b..4f072c4d4 100644 --- a/host/lib/usrp/b200/b200_io_impl.cpp +++ b/host/lib/usrp/b200/b200_io_impl.cpp @@ -72,44 +72,31 @@ void b200_impl::update_tx_samp_rate(const size_t dspno, const double rate)  /***********************************************************************   * frontend selection   **********************************************************************/ -void b200_impl::update_rx_subdev_spec(const uhd::usrp::subdev_spec_t &spec) +void b200_impl::update_subdev_spec(const std::string &tx_rx, const uhd::usrp::subdev_spec_t &spec)  {      //sanity checking -    if (spec.size()) validate_subdev_spec(_tree, spec, "rx"); +    if (spec.size()) validate_subdev_spec(_tree, spec, tx_rx);      UHD_ASSERT_THROW(spec.size() <= _radio_perifs.size()); -    if (spec.size() > 0) +    if (spec.size() >= 1)      {          UHD_ASSERT_THROW(spec[0].db_name == "A"); -        UHD_ASSERT_THROW(spec[0].sd_name == "A"); +        UHD_ASSERT_THROW(spec[0].sd_name == "A" or spec[0].sd_name == "B");      } -    if (spec.size() > 1) +    if (spec.size() == 2)      { -        //TODO we can support swapping at a later date, only this combo is supported          UHD_ASSERT_THROW(spec[1].db_name == "A"); -        UHD_ASSERT_THROW(spec[1].sd_name == "B"); +        UHD_ASSERT_THROW( +            (spec[0].sd_name == "A" and spec[1].sd_name == "B") or +            (spec[0].sd_name == "B" and spec[1].sd_name == "A") +        );      } -    this->update_enables(); -} - -void b200_impl::update_tx_subdev_spec(const uhd::usrp::subdev_spec_t &spec) -{ -    //sanity checking -    if (spec.size()) validate_subdev_spec(_tree, spec, "tx"); -    UHD_ASSERT_THROW(spec.size() <= _radio_perifs.size()); - -    if (spec.size() > 0) -    { -        UHD_ASSERT_THROW(spec[0].db_name == "A"); -        UHD_ASSERT_THROW(spec[0].sd_name == "A"); -    } -    if (spec.size() > 1) -    { -        //TODO we can support swapping at a later date, only this combo is supported -        UHD_ASSERT_THROW(spec[1].db_name == "A"); -        UHD_ASSERT_THROW(spec[1].sd_name == "B"); +    std::vector<size_t> chan_to_dsp_map(spec.size(), 0); +    for (size_t i = 0; i < spec.size(); i++) { +	chan_to_dsp_map[i] = (spec[i].sd_name == "A") ? 0 : 1;      } +    _tree->access<std::vector<size_t> >("/mboards/0" / (tx_rx + "_chan_dsp_mapping")).set(chan_to_dsp_map);      this->update_enables();  } @@ -238,13 +225,14 @@ rx_streamer::sptr b200_impl::get_rx_stream(const uhd::stream_args_t &args_)      boost::shared_ptr<sph::recv_packet_streamer> my_streamer;      for (size_t stream_i = 0; stream_i < args.channels.size(); stream_i++)      { -        const size_t chan = args.channels[stream_i]; -        radio_perifs_t &perif = _radio_perifs[chan]; +        const size_t radio_index = _tree->access<std::vector<size_t> >("/mboards/0/rx_chan_dsp_mapping") +                                        .get().at(args.channels[stream_i]); +        radio_perifs_t &perif = _radio_perifs[radio_index];          if (args.otw_format == "sc16") perif.ctrl->poke32(TOREG(SR_RX_FMT), 0);          if (args.otw_format == "sc12") perif.ctrl->poke32(TOREG(SR_RX_FMT), 1);          if (args.otw_format == "fc32") perif.ctrl->poke32(TOREG(SR_RX_FMT), 2);          if (args.otw_format == "sc8") perif.ctrl->poke32(TOREG(SR_RX_FMT), 3); -        const boost::uint32_t sid = chan?B200_RX_DATA1_SID:B200_RX_DATA0_SID; +        const boost::uint32_t sid = radio_index ? B200_RX_DATA1_SID : B200_RX_DATA0_SID;          //calculate packet size          static const size_t hdr_size = 0 @@ -283,7 +271,7 @@ rx_streamer::sptr b200_impl::get_rx_stream(const uhd::stream_args_t &args_)              &recv_packet_demuxer_3000::get_recv_buff, _demux, sid, _1          ), true /*flush*/);          my_streamer->set_overflow_handler(stream_i, boost::bind( -            &b200_impl::handle_overflow, this, chan +            &b200_impl::handle_overflow, this, radio_index          ));          my_streamer->set_issue_stream_cmd(stream_i, boost::bind(              &rx_vita_core_3000::issue_stream_command, perif.framer, _1 @@ -292,21 +280,21 @@ rx_streamer::sptr b200_impl::get_rx_stream(const uhd::stream_args_t &args_)          //sets all tick and samp rates on this streamer          this->update_tick_rate(this->get_tick_rate()); -        _tree->access<double>(str(boost::format("/mboards/0/rx_dsps/%u/rate/value") % chan)).update(); +        _tree->access<double>(str(boost::format("/mboards/0/rx_dsps/%u/rate/value") % radio_index)).update();      }      this->update_enables();      return my_streamer;  } -void b200_impl::handle_overflow(const size_t i) +void b200_impl::handle_overflow(const size_t radio_index)  {      boost::shared_ptr<sph::recv_packet_streamer> my_streamer = -            boost::dynamic_pointer_cast<sph::recv_packet_streamer>(_radio_perifs[i].rx_streamer.lock()); +            boost::dynamic_pointer_cast<sph::recv_packet_streamer>(_radio_perifs[radio_index].rx_streamer.lock());      if (my_streamer->get_num_channels() == 2) //MIMO time      {          //find out if we were in continuous mode before stopping -        const bool in_continuous_streaming_mode = _radio_perifs[i].framer->in_continuous_streaming_mode(); +        const bool in_continuous_streaming_mode = _radio_perifs[radio_index].framer->in_continuous_streaming_mode();          //stop streaming          my_streamer->issue_stream_cmd(stream_cmd_t::STREAM_MODE_STOP_CONTINUOUS);          //flush demux @@ -319,11 +307,11 @@ void b200_impl::handle_overflow(const size_t i)          {              stream_cmd_t stream_cmd(stream_cmd_t::STREAM_MODE_START_CONTINUOUS);              stream_cmd.stream_now = false; -            stream_cmd.time_spec = _radio_perifs[i].time64->get_time_now() + time_spec_t(0.01); +            stream_cmd.time_spec = _radio_perifs[radio_index].time64->get_time_now() + time_spec_t(0.01);              my_streamer->issue_stream_cmd(stream_cmd);          }      } -    else _radio_perifs[i].framer->handle_overflow(); +    else _radio_perifs[radio_index].framer->handle_overflow();  }  /*********************************************************************** @@ -340,8 +328,9 @@ tx_streamer::sptr b200_impl::get_tx_stream(const uhd::stream_args_t &args_)      boost::shared_ptr<sph::send_packet_streamer> my_streamer;      for (size_t stream_i = 0; stream_i < args.channels.size(); stream_i++)      { -        const size_t chan = args.channels[stream_i]; -        radio_perifs_t &perif = _radio_perifs[chan]; +        const size_t radio_index = _tree->access<std::vector<size_t> >("/mboards/0/tx_chan_dsp_mapping") +                                        .get().at(args.channels[stream_i]); +        radio_perifs_t &perif = _radio_perifs[radio_index];          if (args.otw_format == "sc16") perif.ctrl->poke32(TOREG(SR_TX_FMT), 0);          if (args.otw_format == "sc12") perif.ctrl->poke32(TOREG(SR_TX_FMT), 1);          if (args.otw_format == "fc32") perif.ctrl->poke32(TOREG(SR_TX_FMT), 2); @@ -382,13 +371,13 @@ tx_streamer::sptr b200_impl::get_tx_stream(const uhd::stream_args_t &args_)          my_streamer->set_async_receiver(boost::bind(              &async_md_type::pop_with_timed_wait, _async_task_data->async_md, _1, _2          )); -        my_streamer->set_xport_chan_sid(stream_i, true, chan?B200_TX_DATA1_SID:B200_TX_DATA0_SID); +        my_streamer->set_xport_chan_sid(stream_i, true, radio_index ? B200_TX_DATA1_SID : B200_TX_DATA0_SID);          my_streamer->set_enable_trailer(false); //TODO not implemented trailer support yet          perif.tx_streamer = my_streamer; //store weak pointer          //sets all tick and samp rates on this streamer          this->update_tick_rate(this->get_tick_rate()); -        _tree->access<double>(str(boost::format("/mboards/0/tx_dsps/%u/rate/value") % chan)).update(); +        _tree->access<double>(str(boost::format("/mboards/0/tx_dsps/%u/rate/value") % radio_index)).update();      }      this->update_enables(); diff --git a/host/lib/usrp/multi_usrp.cpp b/host/lib/usrp/multi_usrp.cpp index 182e774fc..2e82e890e 100644 --- a/host/lib/usrp/multi_usrp.cpp +++ b/host/lib/usrp/multi_usrp.cpp @@ -35,14 +35,20 @@ using namespace uhd::usrp;  const std::string multi_usrp::ALL_GAINS = ""; -UHD_INLINE std::string string_vector_to_string(std::vector<std::string> values, std::string delimeter = std::string(" ")) +UHD_INLINE std::string string_vector_to_string(std::vector<std::string> values, std::string delimiter = std::string(" "))  {      std::string out = "";      for (std::vector<std::string>::iterator iter = values.begin(); iter != values.end(); iter++) -        out += delimeter + *iter; +    { +        out += (iter != values.begin() ? delimiter : "") + *iter; +    }      return out;  } +#define THROW_GAIN_NAME_ERROR(name,chan,dir) throw uhd::exception::runtime_error( \ +            (boost::format("%s: gain \"%s\" not found for channel %d.\nAvailable gains: %s\n") % \ +            __FUNCTION__ % name % chan % string_vector_to_string(get_##dir##_gain_names(chan))).str()); +  /***********************************************************************   * Helper methods   **********************************************************************/ @@ -671,10 +677,7 @@ public:          try {              return rx_gain_group(chan)->set_value(gain, name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,rx);          }      } @@ -682,10 +685,7 @@ public:          try {              return rx_gain_group(chan)->get_value(name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,rx);          }      } @@ -693,10 +693,7 @@ public:          try {              return rx_gain_group(chan)->get_range(name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,rx);          }      } @@ -861,10 +858,7 @@ public:          try {              return tx_gain_group(chan)->set_value(gain, name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,tx);          }      } @@ -872,10 +866,7 @@ public:          try {              return tx_gain_group(chan)->get_value(name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,tx);          }      } @@ -883,10 +874,7 @@ public:          try {              return tx_gain_group(chan)->get_range(name);          } catch (uhd::key_error &e) { -            std::stringstream err; -            err << __FUNCTION__ << "(\"" << name << "\"): gain not found.\n" << -                "Available gains: " << string_vector_to_string(get_rx_gain_names(chan)) << std::endl; -            throw uhd::exception::runtime_error(err.str()); +            THROW_GAIN_NAME_ERROR(name,chan,tx);          }      } @@ -1073,6 +1061,12 @@ private:      fs_path rx_dsp_root(const size_t chan)      {          mboard_chan_pair mcp = rx_chan_to_mcp(chan); +        if (_tree->exists(mb_root(mcp.mboard) / "rx_chan_dsp_mapping")) { +            std::vector<size_t> map = _tree->access<std::vector<size_t> >(mb_root(mcp.mboard) / "rx_chan_dsp_mapping").get(); +            UHD_ASSERT_THROW(map.size() >= mcp.chan); +            mcp.chan = map[mcp.chan]; +        } +          try          {              const std::string name = _tree->list(mb_root(mcp.mboard) / "rx_dsps").at(mcp.chan); @@ -1087,6 +1081,11 @@ private:      fs_path tx_dsp_root(const size_t chan)      {          mboard_chan_pair mcp = tx_chan_to_mcp(chan); +        if (_tree->exists(mb_root(mcp.mboard) / "tx_chan_dsp_mapping")) { +            std::vector<size_t> map = _tree->access<std::vector<size_t> >(mb_root(mcp.mboard) / "tx_chan_dsp_mapping").get(); +            UHD_ASSERT_THROW(map.size() >= mcp.chan); +            mcp.chan = map[mcp.chan]; +        }          try          {              const std::string name = _tree->list(mb_root(mcp.mboard) / "tx_dsps").at(mcp.chan); diff --git a/host/lib/usrp/x300/x300_impl.cpp b/host/lib/usrp/x300/x300_impl.cpp index b20897fc6..48b9e9bd4 100644 --- a/host/lib/usrp/x300/x300_impl.cpp +++ b/host/lib/usrp/x300/x300_impl.cpp @@ -430,16 +430,16 @@ void x300_impl::setup_mb(const size_t mb_i, const uhd::device_addr_t &dev_addr)          // Detect the frame size on the path to the USRP          try { -            max_frame_sizes = determine_max_frame_size(mb.addr, req_max_frame_size); +            _max_frame_sizes = determine_max_frame_size(mb.addr, req_max_frame_size);          } catch(std::exception &e) {              UHD_MSG(error) << e.what() << std::endl;          }          if ((mb.recv_args.has_key("recv_frame_size")) -                && (req_max_frame_size.recv_frame_size < max_frame_sizes.recv_frame_size)) { +                && (req_max_frame_size.recv_frame_size < _max_frame_sizes.recv_frame_size)) {              UHD_MSG(warning)                  << boost::format("You requested a receive frame size of (%lu) but your NIC's max frame size is (%lu).") -                % req_max_frame_size.recv_frame_size << max_frame_sizes.recv_frame_size << std::endl +                % req_max_frame_size.recv_frame_size << _max_frame_sizes.recv_frame_size << std::endl                  << boost::format("Please verify your NIC's MTU setting using '%s' or set the recv_frame_size argument appropriately.")                  % mtu_tool << std::endl                  << "UHD will use the auto-detected max frame size for this connection." @@ -447,10 +447,10 @@ void x300_impl::setup_mb(const size_t mb_i, const uhd::device_addr_t &dev_addr)          }          if ((mb.recv_args.has_key("send_frame_size")) -                && (req_max_frame_size.send_frame_size < max_frame_sizes.send_frame_size)) { +                && (req_max_frame_size.send_frame_size < _max_frame_sizes.send_frame_size)) {              UHD_MSG(warning)                  << boost::format("You requested a send frame size of (%lu) but your NIC's max frame size is (%lu).") -                % req_max_frame_size.send_frame_size << max_frame_sizes.send_frame_size << std::endl +                % req_max_frame_size.send_frame_size << _max_frame_sizes.send_frame_size << std::endl                  << boost::format("Please verify your NIC's MTU setting using '%s' or set the send_frame_size argument appropriately.")                  % mtu_tool << std::endl                  << "UHD will use the auto-detected max frame size for this connection." @@ -458,8 +458,6 @@ void x300_impl::setup_mb(const size_t mb_i, const uhd::device_addr_t &dev_addr)          }      } -    const std::vector<std::string> DB_NAMES = boost::assign::list_of("A")("B"); -      //create basic communication      UHD_MSG(status) << "Setup basic communication..." << std::endl;      if (mb.xport_path == "nirio") { @@ -664,8 +662,8 @@ void x300_impl::setup_mb(const size_t mb_i, const uhd::device_addr_t &dev_addr)      // setup radios      ////////////////////////////////////////////////////////////////////      UHD_MSG(status) << "Initialize Radio control..." << std::endl; -    this->setup_radio(mb_i, 0, DB_NAMES[0]); -    this->setup_radio(mb_i, 1, DB_NAMES[1]); +    this->setup_radio(mb_i, "A"); +    this->setup_radio(mb_i, "B");      ////////////////////////////////////////////////////////////////////      // front panel gpio @@ -732,10 +730,13 @@ void x300_impl::setup_mb(const size_t mb_i, const uhd::device_addr_t &dev_addr)      ////////////////////////////////////////////////////////////////////      // create frontend mapping      //////////////////////////////////////////////////////////////////// +    std::vector<size_t> default_map(2, 0); default_map[1] = 1; +    _tree->create<std::vector<size_t> >(mb_path / "rx_chan_dsp_mapping").set(default_map); +    _tree->create<std::vector<size_t> >(mb_path / "tx_chan_dsp_mapping").set(default_map);      _tree->create<subdev_spec_t>(mb_path / "rx_subdev_spec") -        .subscribe(boost::bind(&x300_impl::update_rx_subdev_spec, this, mb_i, _1)); +        .subscribe(boost::bind(&x300_impl::update_subdev_spec, this, "rx", mb_i, _1));      _tree->create<subdev_spec_t>(mb_path / "tx_subdev_spec") -        .subscribe(boost::bind(&x300_impl::update_tx_subdev_spec, this, mb_i, _1)); +        .subscribe(boost::bind(&x300_impl::update_subdev_spec, this, "tx", mb_i, _1));      ////////////////////////////////////////////////////////////////////      // and do the misc mboard sensors @@ -824,20 +825,20 @@ static void check_adc(wb_iface::sptr iface, const boost::uint32_t val)      UHD_ASSERT_THROW(adc_rb == val);  } -void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string &db_name) +void x300_impl::setup_radio(const size_t mb_i, const std::string &slot_name)  {      const fs_path mb_path = "/mboards/"+boost::lexical_cast<std::string>(mb_i); +    const size_t radio_index = _mb[mb_i].get_radio_index(slot_name);      mboard_members_t &mb = _mb[mb_i]; -    radio_perifs_t &perif = mb.radio_perifs[i]; -    const size_t dspno = i; +    radio_perifs_t &perif = mb.radio_perifs[radio_index];      ////////////////////////////////////////////////////////////////////      // radio control      //////////////////////////////////////////////////////////////////// -    uint8_t dest = (i == 0)? X300_XB_DST_R0 : X300_XB_DST_R1; +    uint8_t dest = (radio_index == 0)? X300_XB_DST_R0 : X300_XB_DST_R1;      boost::uint32_t ctrl_sid;      both_xports_t xport = this->make_transport(mb_i, dest, X300_RADIO_DEST_PREFIX_CTRL, device_addr_t(), ctrl_sid); -    perif.ctrl = radio_ctrl_core_3000::make(mb.if_pkt_is_big_endian, xport.recv, xport.send, ctrl_sid, db_name); +    perif.ctrl = radio_ctrl_core_3000::make(mb.if_pkt_is_big_endian, xport.recv, xport.send, ctrl_sid, slot_name);      perif.ctrl->poke32(TOREG(SR_MISC_OUTS), (1 << 2)); //reset adc + dac      perif.ctrl->poke32(TOREG(SR_MISC_OUTS),  (1 << 1) | (1 << 0)); //out of reset + dac enable @@ -883,20 +884,20 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string      ////////////////////////////////////////////////////////////////      // create codec control objects      //////////////////////////////////////////////////////////////// -    _tree->create<int>(mb_path / "rx_codecs" / db_name / "gains"); //phony property so this dir exists -    _tree->create<int>(mb_path / "tx_codecs" / db_name / "gains"); //phony property so this dir exists -    _tree->create<std::string>(mb_path / "rx_codecs" / db_name / "name").set("ads62p48"); -    _tree->create<std::string>(mb_path / "tx_codecs" / db_name / "name").set("ad9146"); +    _tree->create<int>(mb_path / "rx_codecs" / slot_name / "gains"); //phony property so this dir exists +    _tree->create<int>(mb_path / "tx_codecs" / slot_name / "gains"); //phony property so this dir exists +    _tree->create<std::string>(mb_path / "rx_codecs" / slot_name / "name").set("ads62p48"); +    _tree->create<std::string>(mb_path / "tx_codecs" / slot_name / "name").set("ad9146"); -    _tree->create<meta_range_t>(mb_path / "rx_codecs" / db_name / "gains" / "digital" / "range").set(meta_range_t(0, 6.0, 0.5)); -    _tree->create<double>(mb_path / "rx_codecs" / db_name / "gains" / "digital" / "value") +    _tree->create<meta_range_t>(mb_path / "rx_codecs" / slot_name / "gains" / "digital" / "range").set(meta_range_t(0, 6.0, 0.5)); +    _tree->create<double>(mb_path / "rx_codecs" / slot_name / "gains" / "digital" / "value")          .subscribe(boost::bind(&x300_adc_ctrl::set_gain, perif.adc, _1)).set(0);      ////////////////////////////////////////////////////////////////////      // front end corrections      ////////////////////////////////////////////////////////////////////      perif.rx_fe = rx_frontend_core_200::make(perif.ctrl, TOREG(SR_RX_FRONT)); -    const fs_path rx_fe_path = mb_path / "rx_frontends" / db_name; +    const fs_path rx_fe_path = mb_path / "rx_frontends" / slot_name;      _tree->create<std::complex<double> >(rx_fe_path / "dc_offset" / "value")          .coerce(boost::bind(&rx_frontend_core_200::set_dc_offset, perif.rx_fe, _1))          .set(std::complex<double>(0.0, 0.0)); @@ -908,7 +909,7 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string          .set(std::complex<double>(0.0, 0.0));      perif.tx_fe = tx_frontend_core_200::make(perif.ctrl, TOREG(SR_TX_FRONT)); -    const fs_path tx_fe_path = mb_path / "tx_frontends" / db_name; +    const fs_path tx_fe_path = mb_path / "tx_frontends" / slot_name;      _tree->create<std::complex<double> >(tx_fe_path / "dc_offset" / "value")          .coerce(boost::bind(&tx_frontend_core_200::set_dc_offset, perif.tx_fe, _1))          .set(std::complex<double>(0.0, 0.0)); @@ -927,12 +928,12 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string      _tree->access<double>(mb_path / "tick_rate")          .subscribe(boost::bind(&rx_vita_core_3000::set_tick_rate, perif.framer, _1))          .subscribe(boost::bind(&rx_dsp_core_3000::set_tick_rate, perif.ddc, _1)); -    const fs_path rx_dsp_path = mb_path / "rx_dsps" / str(boost::format("%u") % dspno); +    const fs_path rx_dsp_path = mb_path / "rx_dsps" / str(boost::format("%u") % radio_index);      _tree->create<meta_range_t>(rx_dsp_path / "rate" / "range")          .publish(boost::bind(&rx_dsp_core_3000::get_host_rates, perif.ddc));      _tree->create<double>(rx_dsp_path / "rate" / "value")          .coerce(boost::bind(&rx_dsp_core_3000::set_host_rate, perif.ddc, _1)) -        .subscribe(boost::bind(&x300_impl::update_rx_samp_rate, this, boost::ref(mb), dspno, _1)) +        .subscribe(boost::bind(&x300_impl::update_rx_samp_rate, this, boost::ref(mb), radio_index, _1))          .set(1e6);      _tree->create<double>(rx_dsp_path / "freq" / "value")          .coerce(boost::bind(&rx_dsp_core_3000::set_freq, perif.ddc, _1)) @@ -951,12 +952,12 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string      _tree->access<double>(mb_path / "tick_rate")          .subscribe(boost::bind(&tx_vita_core_3000::set_tick_rate, perif.deframer, _1))          .subscribe(boost::bind(&tx_dsp_core_3000::set_tick_rate, perif.duc, _1)); -    const fs_path tx_dsp_path = mb_path / "tx_dsps" / str(boost::format("%u") % dspno); +    const fs_path tx_dsp_path = mb_path / "tx_dsps" / str(boost::format("%u") % radio_index);      _tree->create<meta_range_t>(tx_dsp_path / "rate" / "range")          .publish(boost::bind(&tx_dsp_core_3000::get_host_rates, perif.duc));      _tree->create<double>(tx_dsp_path / "rate" / "value")          .coerce(boost::bind(&tx_dsp_core_3000::set_host_rate, perif.duc, _1)) -        .subscribe(boost::bind(&x300_impl::update_tx_samp_rate, this, boost::ref(mb), dspno, _1)) +        .subscribe(boost::bind(&x300_impl::update_tx_samp_rate, this, boost::ref(mb), radio_index, _1))          .set(1e6);      _tree->create<double>(tx_dsp_path / "freq" / "value")          .coerce(boost::bind(&tx_dsp_core_3000::set_freq, perif.duc, _1)) @@ -975,14 +976,15 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string      ////////////////////////////////////////////////////////////////////      // create RF frontend interfacing      //////////////////////////////////////////////////////////////////// -    const size_t j = (db_name == "B")? 0x2 : 0x0; -    _tree->create<dboard_eeprom_t>(mb_path / "dboards" / db_name / "rx_eeprom") +    const fs_path db_path = (mb_path / "dboards" / slot_name); +    const size_t j = (slot_name == "B")? 0x2 : 0x0; +    _tree->create<dboard_eeprom_t>(db_path / "rx_eeprom")          .set(mb.db_eeproms[X300_DB0_RX_EEPROM | j])          .subscribe(boost::bind(&x300_impl::set_db_eeprom, this, mb.zpu_i2c, (0x50 | X300_DB0_RX_EEPROM | j), _1)); -    _tree->create<dboard_eeprom_t>(mb_path / "dboards" / db_name / "tx_eeprom") +    _tree->create<dboard_eeprom_t>(db_path / "tx_eeprom")          .set(mb.db_eeproms[X300_DB0_TX_EEPROM | j])          .subscribe(boost::bind(&x300_impl::set_db_eeprom, this, mb.zpu_i2c, (0x50 | X300_DB0_TX_EEPROM | j), _1)); -    _tree->create<dboard_eeprom_t>(mb_path / "dboards" / db_name / "gdb_eeprom") +    _tree->create<dboard_eeprom_t>(db_path / "gdb_eeprom")          .set(mb.db_eeproms[X300_DB0_GDB_EEPROM | j])          .subscribe(boost::bind(&x300_impl::set_db_eeprom, this, mb.zpu_i2c, (0x50 | X300_DB0_GDB_EEPROM | j), _1)); @@ -994,33 +996,33 @@ void x300_impl::setup_radio(const size_t mb_i, const size_t i, const std::string      db_config.tx_spi_slaveno = DB_TX_SEN;      db_config.i2c = mb.zpu_i2c;      db_config.clock = mb.clock; -    db_config.which_rx_clk = (db_name == "A")? X300_CLOCK_WHICH_DB0_RX : X300_CLOCK_WHICH_DB1_RX; -    db_config.which_tx_clk = (db_name == "A")? X300_CLOCK_WHICH_DB0_TX : X300_CLOCK_WHICH_DB1_TX; -    db_config.dboard_slot = (db_name == "A")? 0 : 1; -    _dboard_ifaces[db_name] = x300_make_dboard_iface(db_config); +    db_config.which_rx_clk = (slot_name == "A")? X300_CLOCK_WHICH_DB0_RX : X300_CLOCK_WHICH_DB1_RX; +    db_config.which_tx_clk = (slot_name == "A")? X300_CLOCK_WHICH_DB0_TX : X300_CLOCK_WHICH_DB1_TX; +    db_config.dboard_slot = (slot_name == "A")? 0 : 1; +    _dboard_ifaces[db_path] = x300_make_dboard_iface(db_config);      //create a new dboard manager -    _tree->create<dboard_iface::sptr>(mb_path / "dboards" / db_name / "iface").set(_dboard_ifaces[db_name]); -    _dboard_managers[db_name] = dboard_manager::make( +    _tree->create<dboard_iface::sptr>(db_path / "iface").set(_dboard_ifaces[db_path]); +    _dboard_managers[db_path] = dboard_manager::make(          mb.db_eeproms[X300_DB0_RX_EEPROM | j].id,          mb.db_eeproms[X300_DB0_TX_EEPROM | j].id,          mb.db_eeproms[X300_DB0_GDB_EEPROM | j].id, -        _dboard_ifaces[db_name], -        _tree->subtree(mb_path / "dboards" / db_name) +        _dboard_ifaces[db_path], +        _tree->subtree(db_path)      );      //now that dboard is created -- register into rx antenna event -    const std::string fe_name = _tree->list(mb_path / "dboards" / db_name / "rx_frontends").front(); -    _tree->access<std::string>(mb_path / "dboards" / db_name / "rx_frontends" / fe_name / "antenna" / "value") -        .subscribe(boost::bind(&x300_impl::update_atr_leds, this, mb.radio_perifs[i].leds, _1)); -    this->update_atr_leds(mb.radio_perifs[i].leds, ""); //init anyway, even if never called +    const std::string fe_name = _tree->list(db_path / "rx_frontends").front(); +    _tree->access<std::string>(db_path / "rx_frontends" / fe_name / "antenna" / "value") +        .subscribe(boost::bind(&x300_impl::update_atr_leds, this, mb.radio_perifs[radio_index].leds, _1)); +    this->update_atr_leds(mb.radio_perifs[radio_index].leds, ""); //init anyway, even if never called      //bind frontend corrections to the dboard freq props -    const fs_path db_rx_fe_path = mb_path / "dboards" / db_name / "rx_frontends"; +    const fs_path db_rx_fe_path = db_path / "rx_frontends";      BOOST_FOREACH(const std::string &name, _tree->list(db_rx_fe_path))      {          _tree->access<double>(db_rx_fe_path / name / "freq" / "value") -            .subscribe(boost::bind(&x300_impl::set_rx_fe_corrections, this, mb_path, db_name, _1)); +            .subscribe(boost::bind(&x300_impl::set_rx_fe_corrections, this, mb_path, slot_name, _1));      }  } @@ -1120,29 +1122,28 @@ x300_impl::both_xports_t x300_impl::make_transport(          /* Print a warning if the system's max available frame size is less than the most optimal           * frame size for this type of connection. */ -        if (max_frame_sizes.send_frame_size < eth_data_rec_frame_size) { +        if (_max_frame_sizes.send_frame_size < eth_data_rec_frame_size) {              UHD_MSG(warning)                  << boost::format("For this connection, UHD recommends a send frame size of at least %lu for best\nperformance, but your system's MTU will only allow %lu.")                  % eth_data_rec_frame_size -                % max_frame_sizes.send_frame_size +                % _max_frame_sizes.send_frame_size                  << std::endl                  << "This will negatively impact your maximum achievable sample rate."                  << std::endl;          } -        if (max_frame_sizes.recv_frame_size < eth_data_rec_frame_size) { +        if (_max_frame_sizes.recv_frame_size < eth_data_rec_frame_size) {              UHD_MSG(warning)                  << boost::format("For this connection, UHD recommends a receive frame size of at least %lu for best\nperformance, but your system's MTU will only allow %lu.")                  % eth_data_rec_frame_size -                % max_frame_sizes.recv_frame_size +                % _max_frame_sizes.recv_frame_size                  << std::endl                  << "This will negatively impact your maximum achievable sample rate."                  << std::endl;          } -	// Account for headers -        size_t system_max_send_frame_size = (size_t) max_frame_sizes.send_frame_size - 64; -        size_t system_max_recv_frame_size = (size_t) max_frame_sizes.recv_frame_size - 64; +	size_t system_max_send_frame_size = (size_t) _max_frame_sizes.send_frame_size; +	size_t system_max_recv_frame_size = (size_t) _max_frame_sizes.recv_frame_size;  	// Make sure frame sizes do not exceed the max available value supported by UHD          default_buff_args.send_frame_size = @@ -1165,7 +1166,7 @@ x300_impl::both_xports_t x300_impl::make_transport(              ? X300_ETH_DATA_NUM_FRAMES              : X300_ETH_MSG_NUM_FRAMES; -        //make a new transport - fpga has no idea how to talk to use on this yet +        //make a new transport - fpga has no idea how to talk to us on this yet          udp_zero_copy::buff_params buff_params;          xports.recv = udp_zero_copy::make(mb.addr,                  BOOST_STRINGIZE(X300_VITA_UDP_PORT), diff --git a/host/lib/usrp/x300/x300_impl.hpp b/host/lib/usrp/x300/x300_impl.hpp index 1fb3676a0..1e159ef38 100644 --- a/host/lib/usrp/x300/x300_impl.hpp +++ b/host/lib/usrp/x300/x300_impl.hpp @@ -82,8 +82,8 @@ static const double X300_DEFAULT_SYSREF_RATE        = 10e6;  #define X300_XB_DST_E0 0  #define X300_XB_DST_E1 1 -#define X300_XB_DST_R0 2 -#define X300_XB_DST_R1 3 +#define X300_XB_DST_R0 2 // Radio 0 -> Slot A +#define X300_XB_DST_R1 3 // Radio 1 -> Slot B  #define X300_XB_DST_CE0 4  #define X300_XB_DST_CE1 5  #define X300_XB_DST_CE2 5 @@ -191,12 +191,13 @@ private:          i2c_core_100_wb32::sptr zpu_i2c;          //perifs in each radio -        radio_perifs_t radio_perifs[2]; +        radio_perifs_t radio_perifs[2]; //!< This is hardcoded s.t. radio_perifs[0] points to slot A and [1] to B          uhd::usrp::dboard_eeprom_t db_eeproms[8]; - -        //per mboard frontend mapping -        uhd::usrp::subdev_spec_t rx_fe_map; -        uhd::usrp::subdev_spec_t tx_fe_map; +	//! Return the index of a radio component, given a slot name. This means DSPs, radio_perifs +        size_t get_radio_index(const std::string &slot_name) { +             UHD_ASSERT_THROW(slot_name == "A" or slot_name == "B"); +             return slot_name == "A" ? 0 : 1; +        }          //other perifs on mboard          x300_clock_ctrl::sptr clock; @@ -222,7 +223,20 @@ private:      void register_loopback_self_test(uhd::wb_iface::sptr iface); -    void setup_radio(const size_t, const size_t which_radio, const std::string &db_name); +     /*! \brief Initialize the radio component on a given slot. +      * +      * Call this function once per slot (A and B) and motherboard to initialize all the radio components. +      * This will: +      * - Reset and init DACs and ADCs +      * - Setup controls for DAC, ADC, SPI and LEDs +      * - Self test ADC +      * - Sync DACs (for MIMO) +      * - Initialize the property tree for control objects etc. (gain, rate...) +      * +      * \param mb_i Motherboard index +      * \param slot_name Slot name (A or B). +      */ +    void setup_radio(const size_t, const std::string &slot_name);      size_t _sid_framer;      struct sid_config_t @@ -253,7 +267,7 @@ private:          size_t recv_frame_size;          size_t send_frame_size;      }; -    frame_size_t max_frame_sizes; +    frame_size_t _max_frame_sizes;      /*!       * Automatically determine the maximum frame size available by sending a UDP packet @@ -288,8 +302,15 @@ private:      void set_rx_fe_corrections(const uhd::fs_path &mb_path, const std::string &fe_name, const double lo_freq); -    void update_rx_subdev_spec(const size_t, const uhd::usrp::subdev_spec_t &spec); -    void update_tx_subdev_spec(const size_t, const uhd::usrp::subdev_spec_t &spec); +    /*! Update the IQ MUX settings for the radio peripheral according to given subdev spec. +     * +     * Also checks if the given subdev is valid for this device and updates the channel to DSP mapping. +     * +     * \param tx_rx "tx" or "rx", depending where you're setting the subdev spec +     * \param mb_i Mainboard index number. +     * \param spec Subdev spec +     */ +    void update_subdev_spec(const std::string &tx_rx, const size_t mb_i, const uhd::usrp::subdev_spec_t &spec);      void set_tick_rate(mboard_members_t &, const double);      void update_tick_rate(mboard_members_t &, const double); diff --git a/host/lib/usrp/x300/x300_io_impl.cpp b/host/lib/usrp/x300/x300_io_impl.cpp index 00a31b8d6..84f96d9f5 100644 --- a/host/lib/usrp/x300/x300_io_impl.cpp +++ b/host/lib/usrp/x300/x300_io_impl.cpp @@ -77,75 +77,50 @@ void x300_impl::update_tx_samp_rate(mboard_members_t &mb, const size_t dspno, co  /***********************************************************************   * Setup dboard muxing for IQ   **********************************************************************/ -void x300_impl::update_rx_subdev_spec(const size_t mb_i, const subdev_spec_t &spec) +void x300_impl::update_subdev_spec(const std::string &tx_rx, const size_t mb_i, const subdev_spec_t &spec)  { +    UHD_ASSERT_THROW(tx_rx == "tx" or tx_rx == "rx");      const std::string mb_name = boost::lexical_cast<std::string>(mb_i); -    fs_path root = "/mboards/"+mb_name+"/dboards"; +    fs_path mb_root = "/mboards/" + mb_name;      //sanity checking -    validate_subdev_spec(_tree, spec, "rx", mb_name); +    validate_subdev_spec(_tree, spec, tx_rx, mb_name);      UHD_ASSERT_THROW(spec.size() <= 2); -    if (spec.size() > 0) UHD_ASSERT_THROW(spec[0].db_name == "A"); -    if (spec.size() > 1) UHD_ASSERT_THROW(spec[1].db_name == "B"); - -    //setup mux for this spec -    for (size_t i = 0; i < 2; i++) +    if (spec.size() == 1) { +         UHD_ASSERT_THROW(spec[0].db_name == "A" || spec[0].db_name == "B"); +     } +     if (spec.size() == 2) { +         UHD_ASSERT_THROW( +             (spec[0].db_name == "A" && spec[1].db_name == "B") || +             (spec[0].db_name == "B" && spec[1].db_name == "A") +         ); +     } + +    std::vector<size_t> chan_to_dsp_map(spec.size(), 0); +    // setup mux for this spec +    for (size_t i = 0; i < spec.size(); i++)      { -        //extract db name -        const std::string db_name = (i == 0)? "A" : "B"; -        if (i < spec.size()) UHD_ASSERT_THROW(spec[i].db_name == db_name); - -        //extract fe name -        std::string fe_name; -        if (i < spec.size()) fe_name = spec[i].sd_name; -        else fe_name = _tree->list(root / db_name / "rx_frontends").front(); +        const int radio_idx = _mb[mb_i].get_radio_index(spec[i].db_name); +        chan_to_dsp_map[i] = radio_idx;          //extract connection -        const std::string conn = _tree->access<std::string>(root / db_name / "rx_frontends" / fe_name / "connection").get(); - -        //swap condition -        const bool fe_swapped = (conn == "QI" or conn == "Q"); -        _mb[mb_i].radio_perifs[i].ddc->set_mux(conn, fe_swapped); -        //see usrp/io_impl.cpp if multiple DSPs share the frontend: -        _mb[mb_i].radio_perifs[i].rx_fe->set_mux(fe_swapped); +	const std::string conn = _tree->access<std::string>(mb_root / "dboards" / spec[i].db_name / (tx_rx + "_frontends") / spec[i].sd_name / "connection").get(); + +	if (tx_rx == "tx") { +            //swap condition +            _mb[mb_i].radio_perifs[radio_idx].tx_fe->set_mux(conn); +	} else { +            //swap condition +            const bool fe_swapped = (conn == "QI" or conn == "Q"); +            _mb[mb_i].radio_perifs[radio_idx].ddc->set_mux(conn, fe_swapped); +            //see usrp/io_impl.cpp if multiple DSPs share the frontend: +            _mb[mb_i].radio_perifs[radio_idx].rx_fe->set_mux(fe_swapped); +	}      } -    _mb[mb_i].rx_fe_map = spec; +    _tree->access<std::vector<size_t> >(mb_root / (tx_rx + "_chan_dsp_mapping")).set(chan_to_dsp_map);  } -void x300_impl::update_tx_subdev_spec(const size_t mb_i, const subdev_spec_t &spec) -{ -    const std::string mb_name = boost::lexical_cast<std::string>(mb_i); -    fs_path root = "/mboards/"+mb_name+"/dboards"; - -    //sanity checking -    validate_subdev_spec(_tree, spec, "tx", mb_name); -    UHD_ASSERT_THROW(spec.size() <= 2); -    if (spec.size() > 0) UHD_ASSERT_THROW(spec[0].db_name == "A"); -    if (spec.size() > 1) UHD_ASSERT_THROW(spec[1].db_name == "B"); - -    //set the mux for this spec -    for (size_t i = 0; i < 2; i++) -    { -        //extract db name -        const std::string db_name = (i == 0)? "A" : "B"; -        if (i < spec.size()) UHD_ASSERT_THROW(spec[i].db_name == db_name); - -        //extract fe name -        std::string fe_name; -        if (i < spec.size()) fe_name = spec[i].sd_name; -        else fe_name = _tree->list(root / db_name / "tx_frontends").front(); - -        //extract connection -        const std::string conn = _tree->access<std::string>(root / db_name / "tx_frontends" / fe_name / "connection").get(); - -	//swap condition -        _mb[mb_i].radio_perifs[i].tx_fe->set_mux(conn); - -    } - -    _mb[mb_i].tx_fe_map = spec; -}  /***********************************************************************   * VITA stuff @@ -375,16 +350,24 @@ rx_streamer::sptr x300_impl::get_rx_stream(const uhd::stream_args_t &args_)      boost::shared_ptr<sph::recv_packet_streamer> my_streamer;      for (size_t stream_i = 0; stream_i < args.channels.size(); stream_i++)      { +        // Find the mainboard and subdev that corresponds to channel args.channels[stream_i]          const size_t chan = args.channels[stream_i]; -        size_t mb_chan = chan, mb_index = 0; -        BOOST_FOREACH(mboard_members_t &mb, _mb) -        { -            if (mb_chan < mb.rx_fe_map.size()) break; -            else mb_chan -= mb.rx_fe_map.size(); -            mb_index++; +        size_t mb_chan = chan, mb_index; +        for (mb_index = 0; mb_index < _mb.size(); mb_index++) { +            const subdev_spec_t &curr_subdev_spec = +                _tree->access<subdev_spec_t>("/mboards/" + boost::lexical_cast<std::string>(mb_index) / "rx_subdev_spec").get(); +            if (mb_chan < curr_subdev_spec.size()) { +                break; +            } else { +                mb_chan -= curr_subdev_spec.size(); +            }          } + +        // Find the DSP that corresponds to this mainboard and subdev          mboard_members_t &mb = _mb[mb_index]; -        radio_perifs_t &perif = mb.radio_perifs[mb_chan]; +	const size_t radio_index = _tree->access<std::vector<size_t> >("/mboards/" + boost::lexical_cast<std::string>(mb_index) / "rx_chan_dsp_mapping") +                                            .get().at(mb_chan); +        radio_perifs_t &perif = mb.radio_perifs[radio_index];          //setup the dsp transport hints (default to a large recv buff)          device_addr_t device_addr = mb.recv_args; @@ -405,7 +388,7 @@ rx_streamer::sptr x300_impl::get_rx_stream(const uhd::stream_args_t &args_)          }          //allocate sid and create transport -        uint8_t dest = (mb_chan == 0)? X300_XB_DST_R0 : X300_XB_DST_R1; +        uint8_t dest = (radio_index == 0)? X300_XB_DST_R0 : X300_XB_DST_R1;          boost::uint32_t data_sid;          UHD_LOG << "creating rx stream " << device_addr.to_string() << std::endl;          both_xports_t xport = this->make_transport(mb_index, dest, X300_RADIO_DEST_PREFIX_RX, device_addr, data_sid); @@ -419,9 +402,9 @@ rx_streamer::sptr x300_impl::get_rx_stream(const uhd::stream_args_t &args_)              - sizeof(vrt::if_packet_info_t().cid) //no class id ever used              - sizeof(vrt::if_packet_info_t().tsi) //no int time ever used          ; -        const size_t bpp = xport.recv->get_recv_frame_size() - hdr_size; -        const size_t bpi = convert::get_bytes_per_item(args.otw_format); -        const size_t spp = unsigned(args.args.cast<double>("spp", bpp/bpi)); +        const size_t bpp = xport.recv->get_recv_frame_size() - hdr_size; // bytes per packet +        const size_t bpi = convert::get_bytes_per_item(args.otw_format); // bytes per item +        const size_t spp = unsigned(args.args.cast<double>("spp", bpp/bpi)); // samples per packet          //make the new streamer given the samples per packet          if (not my_streamer) my_streamer = boost::make_shared<sph::recv_packet_streamer>(spp); @@ -488,12 +471,12 @@ rx_streamer::sptr x300_impl::get_rx_stream(const uhd::stream_args_t &args_)          );          //Store a weak pointer to prevent a streamer->x300_impl->streamer circular dependency -        mb.rx_streamers[mb_chan] = boost::weak_ptr<sph::recv_packet_streamer>(my_streamer); +        mb.rx_streamers[radio_index] = boost::weak_ptr<sph::recv_packet_streamer>(my_streamer);          //sets all tick and samp rates on this streamer          const fs_path mb_path = "/mboards/"+boost::lexical_cast<std::string>(mb_index);          _tree->access<double>(mb_path / "tick_rate").update(); -        _tree->access<double>(mb_path / "rx_dsps" / boost::lexical_cast<std::string>(mb_chan) / "rate" / "value").update(); +        _tree->access<double>(mb_path / "rx_dsps" / boost::lexical_cast<std::string>(radio_index) / "rate" / "value").update();      }      return my_streamer; @@ -552,22 +535,29 @@ tx_streamer::sptr x300_impl::get_tx_stream(const uhd::stream_args_t &args_)      boost::shared_ptr<sph::send_packet_streamer> my_streamer;      for (size_t stream_i = 0; stream_i < args.channels.size(); stream_i++)      { +        // Find the mainboard and subdev that corresponds to channel args.channels[stream_i]          const size_t chan = args.channels[stream_i]; -        size_t mb_chan = chan, mb_index = 0; -        BOOST_FOREACH(mboard_members_t &mb, _mb) -        { -            if (mb_chan < mb.tx_fe_map.size()) break; -            else mb_chan -= mb.tx_fe_map.size(); -            mb_index++; +        size_t mb_chan = chan, mb_index; +        for (mb_index = 0; mb_index < _mb.size(); mb_index++) { +            const subdev_spec_t &curr_subdev_spec = +                _tree->access<subdev_spec_t>("/mboards/" + boost::lexical_cast<std::string>(mb_index) / "tx_subdev_spec").get(); +            if (mb_chan < curr_subdev_spec.size()) { +                break; +            } else { +                mb_chan -= curr_subdev_spec.size(); +            }          } +        // Find the DSP that corresponds to this mainboard and subdev          mboard_members_t &mb = _mb[mb_index]; -        radio_perifs_t &perif = mb.radio_perifs[mb_chan]; +	const size_t radio_index = _tree->access<std::vector<size_t> >("/mboards/" + boost::lexical_cast<std::string>(mb_index) / "tx_chan_dsp_mapping") +                                            .get().at(mb_chan); +        radio_perifs_t &perif = mb.radio_perifs[radio_index];          //setup the dsp transport hints (TODO)          device_addr_t device_addr = mb.send_args;          //allocate sid and create transport -        uint8_t dest = (mb_chan == 0)? X300_XB_DST_R0 : X300_XB_DST_R1; +        uint8_t dest = (radio_index == 0)? X300_XB_DST_R0 : X300_XB_DST_R1;          boost::uint32_t data_sid;          UHD_LOG << "creating tx stream " << device_addr.to_string() << std::endl;          both_xports_t xport = this->make_transport(mb_index, dest, X300_RADIO_DEST_PREFIX_TX, device_addr, data_sid); @@ -640,12 +630,12 @@ tx_streamer::sptr x300_impl::get_tx_stream(const uhd::stream_args_t &args_)          my_streamer->set_enable_trailer(false); //TODO not implemented trailer support yet          //Store a weak pointer to prevent a streamer->x300_impl->streamer circular dependency -        mb.tx_streamers[mb_chan] = boost::weak_ptr<sph::send_packet_streamer>(my_streamer); +        mb.tx_streamers[radio_index] = boost::weak_ptr<sph::send_packet_streamer>(my_streamer);          //sets all tick and samp rates on this streamer          const fs_path mb_path = "/mboards/"+boost::lexical_cast<std::string>(mb_index);          _tree->access<double>(mb_path / "tick_rate").update(); -        _tree->access<double>(mb_path / "tx_dsps" / boost::lexical_cast<std::string>(mb_chan) / "rate" / "value").update(); +        _tree->access<double>(mb_path / "tx_dsps" / boost::lexical_cast<std::string>(radio_index) / "rate" / "value").update();      }      return my_streamer; diff --git a/host/utils/uhd_cal_rx_iq_balance.cpp b/host/utils/uhd_cal_rx_iq_balance.cpp index 5fb494114..551da7544 100644 --- a/host/utils/uhd_cal_rx_iq_balance.cpp +++ b/host/utils/uhd_cal_rx_iq_balance.cpp @@ -20,6 +20,7 @@  #include <uhd/utils/safe_main.hpp>  #include <uhd/utils/paths.hpp>  #include <uhd/utils/algorithm.hpp> +#include <uhd/utils/msg.hpp>  #include <uhd/usrp/multi_usrp.hpp>  #include <boost/program_options.hpp>  #include <boost/format.hpp> @@ -93,7 +94,7 @@ static double tune_rx_and_tx(uhd::usrp::multi_usrp::sptr usrp, const double rx_l   * Main   **********************************************************************/  int UHD_SAFE_MAIN(int argc, char *argv[]){ -    std::string args; +    std::string args, subdev, serial;      double tx_wave_ampl, tx_offset;      double freq_start, freq_stop, freq_step;      size_t nsamps; @@ -102,7 +103,8 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      desc.add_options()          ("help", "help message")          ("verbose", "enable some verbose") -        ("args", po::value<std::string>(&args)->default_value(""), "device address args [default = \"\"]") +        ("args", po::value<std::string>(&args)->default_value(""), "Device address args [default = \"\"]") +        ("subdev", po::value<std::string>(&subdev), "Subdevice specification (default: first subdevice, often 'A')")          ("tx_wave_ampl", po::value<double>(&tx_wave_ampl)->default_value(0.7), "Transmit wave amplitude in counts")          ("tx_offset", po::value<double>(&tx_offset)->default_value(.9344e6), "TX LO offset from the RX LO in Hz")          ("freq_start", po::value<double>(&freq_start), "Frequency start in Hz (do not specify for default)") @@ -129,6 +131,15 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      std::cout << boost::format("Creating the usrp device with: %s...") % args << std::endl;      uhd::usrp::multi_usrp::sptr usrp = uhd::usrp::multi_usrp::make(args); +    // Configure subdev +    if (vm.count("subdev")) { +        usrp->set_tx_subdev_spec(subdev); +        usrp->set_rx_subdev_spec(subdev); +    } +    UHD_MSG(status) << "Running calibration for " << usrp->get_tx_subdev_name(0) << std::endl; +    serial = get_serial(usrp, "tx"); +    UHD_MSG(status) << "Daughterboard serial: " << serial << std::endl; +      //set the antennas to cal      if (not uhd::has(usrp->get_rx_antennas(), "CAL") or not uhd::has(usrp->get_tx_antennas(), "CAL")){          throw std::runtime_error("This board does not have the CAL antenna option, cannot self-calibrate."); @@ -158,6 +169,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      if (not vm.count("freq_start")) freq_start = usrp->get_rx_freq_range().start() + 50e6;      if (not vm.count("freq_stop")) freq_stop = usrp->get_rx_freq_range().stop() - 50e6; +    UHD_MSG(status) << boost::format("Calibration frequency range: %d MHz -> %d MHz") % (freq_start/1e6) % (freq_stop/1e6) << std::endl;      for (double rx_lo_i = freq_start; rx_lo_i <= freq_stop; rx_lo_i += freq_step){          const double rx_lo = tune_rx_and_tx(usrp, rx_lo_i, tx_offset); @@ -238,7 +250,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      threads.interrupt_all();      threads.join_all(); -    store_results(usrp, results, "RX", "rx", "iq"); +    store_results(results, "RX", "rx", "iq", serial);      return EXIT_SUCCESS;  } diff --git a/host/utils/uhd_cal_tx_dc_offset.cpp b/host/utils/uhd_cal_tx_dc_offset.cpp index c9cf757f4..eb82db826 100644 --- a/host/utils/uhd_cal_tx_dc_offset.cpp +++ b/host/utils/uhd_cal_tx_dc_offset.cpp @@ -20,6 +20,7 @@  #include <uhd/utils/safe_main.hpp>  #include <uhd/utils/paths.hpp>  #include <uhd/utils/algorithm.hpp> +#include <uhd/utils/msg.hpp>  #include <uhd/usrp/multi_usrp.hpp>  #include <boost/program_options.hpp>  #include <boost/format.hpp> @@ -94,7 +95,7 @@ static double tune_rx_and_tx(uhd::usrp::multi_usrp::sptr usrp, const double tx_l   * Main   **********************************************************************/  int UHD_SAFE_MAIN(int argc, char *argv[]){ -    std::string args; +    std::string args, subdev, serial;      double tx_wave_freq, tx_wave_ampl, rx_offset;      double freq_start, freq_stop, freq_step;      size_t nsamps; @@ -104,6 +105,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){          ("help", "help message")          ("verbose", "enable some verbose")          ("args", po::value<std::string>(&args)->default_value(""), "device address args [default = \"\"]") +        ("subdev", po::value<std::string>(&subdev), "Subdevice specification (default: first subdevice, often 'A')")          ("tx_wave_freq", po::value<double>(&tx_wave_freq)->default_value(507.123e3), "Transmit wave frequency in Hz")          ("tx_wave_ampl", po::value<double>(&tx_wave_ampl)->default_value(0.7), "Transmit wave amplitude in counts")          ("rx_offset", po::value<double>(&rx_offset)->default_value(.9344e6), "RX LO offset from the TX LO in Hz") @@ -131,6 +133,15 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      std::cout << boost::format("Creating the usrp device with: %s...") % args << std::endl;      uhd::usrp::multi_usrp::sptr usrp = uhd::usrp::multi_usrp::make(args); +    // Configure subdev +    if (vm.count("subdev")) { +        usrp->set_tx_subdev_spec(subdev); +        usrp->set_rx_subdev_spec(subdev); +    } +    UHD_MSG(status) << "Running calibration for " << usrp->get_tx_subdev_name(0) << std::endl; +    serial = get_serial(usrp, "tx"); +    UHD_MSG(status) << "Daughterboard serial: " << serial << std::endl; +      //set the antennas to cal      if (not uhd::has(usrp->get_rx_antennas(), "CAL") or not uhd::has(usrp->get_tx_antennas(), "CAL")){          throw std::runtime_error("This board does not have the CAL antenna option, cannot self-calibrate."); @@ -160,6 +171,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      if (not vm.count("freq_start")) freq_start = usrp->get_tx_freq_range().start() + 50e6;      if (not vm.count("freq_stop")) freq_stop = usrp->get_tx_freq_range().stop() - 50e6; +    UHD_MSG(status) << boost::format("Calibration frequency range: %d MHz -> %d MHz") % (freq_start/1e6) % (freq_stop/1e6) << std::endl;      for (double tx_lo_i = freq_start; tx_lo_i <= freq_stop; tx_lo_i += freq_step){          const double tx_lo = tune_rx_and_tx(usrp, tx_lo_i, rx_offset); @@ -235,7 +247,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      threads.interrupt_all();      threads.join_all(); -    store_results(usrp, results, "TX", "tx", "dc"); +    store_results(results, "TX", "tx", "dc", serial);      return EXIT_SUCCESS;  } diff --git a/host/utils/uhd_cal_tx_iq_balance.cpp b/host/utils/uhd_cal_tx_iq_balance.cpp index 20d018edf..786aac061 100644 --- a/host/utils/uhd_cal_tx_iq_balance.cpp +++ b/host/utils/uhd_cal_tx_iq_balance.cpp @@ -20,6 +20,7 @@  #include <uhd/utils/safe_main.hpp>  #include <uhd/utils/paths.hpp>  #include <uhd/utils/algorithm.hpp> +#include <uhd/utils/msg.hpp>  #include <uhd/usrp/multi_usrp.hpp>  #include <boost/program_options.hpp>  #include <boost/format.hpp> @@ -95,7 +96,7 @@ static double tune_rx_and_tx(uhd::usrp::multi_usrp::sptr usrp, const double tx_l   * Main   **********************************************************************/  int UHD_SAFE_MAIN(int argc, char *argv[]){ -    std::string args; +    std::string args, subdev, serial;      double tx_wave_freq, tx_wave_ampl, rx_offset;      double freq_start, freq_stop, freq_step;      size_t nsamps; @@ -105,6 +106,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){          ("help", "help message")          ("verbose", "enable some verbose")          ("args", po::value<std::string>(&args)->default_value(""), "device address args [default = \"\"]") +        ("subdev", po::value<std::string>(&subdev), "Subdevice specification (default: first subdevice, often 'A')")          ("tx_wave_freq", po::value<double>(&tx_wave_freq)->default_value(507.123e3), "Transmit wave frequency in Hz")          ("tx_wave_ampl", po::value<double>(&tx_wave_ampl)->default_value(0.7), "Transmit wave amplitude in counts")          ("rx_offset", po::value<double>(&rx_offset)->default_value(.9344e6), "RX LO offset from the TX LO in Hz") @@ -122,7 +124,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      if (vm.count("help")){          std::cout << boost::format("USRP Generate TX IQ Balance Calibration Table %s") % desc << std::endl;          std::cout << -            "This application measures leakage between RX and TX on an XCVR daughterboard to self-calibrate.\n" +            "This application measures leakage between RX and TX on a daughterboard to self-calibrate.\n"              << std::endl;          return EXIT_FAILURE;      } @@ -132,6 +134,15 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      std::cout << boost::format("Creating the usrp device with: %s...") % args << std::endl;      uhd::usrp::multi_usrp::sptr usrp = uhd::usrp::multi_usrp::make(args); +    // Configure subdev +    if (vm.count("subdev")) { +        usrp->set_tx_subdev_spec(subdev); +        usrp->set_rx_subdev_spec(subdev); +    } +    UHD_MSG(status) << "Running calibration for " << usrp->get_tx_subdev_name(0) << std::endl; +    serial = get_serial(usrp, "tx"); +    UHD_MSG(status) << "Daughterboard serial: " << serial << std::endl; +      //set the antennas to cal      if (not uhd::has(usrp->get_rx_antennas(), "CAL") or not uhd::has(usrp->get_tx_antennas(), "CAL")){          throw std::runtime_error("This board does not have the CAL antenna option, cannot self-calibrate."); @@ -161,6 +172,7 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      if (not vm.count("freq_start")) freq_start = usrp->get_tx_freq_range().start() + 50e6;      if (not vm.count("freq_stop")) freq_stop = usrp->get_tx_freq_range().stop() - 50e6; +    UHD_MSG(status) << boost::format("Calibration frequency range: %d MHz -> %d MHz") % (freq_start/1e6) % (freq_stop/1e6) << std::endl;      for (double tx_lo_i = freq_start; tx_lo_i <= freq_stop; tx_lo_i += freq_step){          const double tx_lo = tune_rx_and_tx(usrp, tx_lo_i, rx_offset); @@ -241,7 +253,8 @@ int UHD_SAFE_MAIN(int argc, char *argv[]){      threads.interrupt_all();      threads.join_all(); -    store_results(usrp, results, "TX", "tx", "iq"); +    store_results(results, "TX", "tx", "iq", serial);      return EXIT_SUCCESS;  } + diff --git a/host/utils/usrp_cal_utils.hpp b/host/utils/usrp_cal_utils.hpp index 40626dfaa..5aff5e22f 100644 --- a/host/utils/usrp_cal_utils.hpp +++ b/host/utils/usrp_cal_utils.hpp @@ -179,27 +179,37 @@ static inline void write_samples_to_file(      outfile.close();  } +  /*********************************************************************** - * Store data to file + * Retrieve d'board serial   **********************************************************************/ -static void store_results( +static std::string get_serial(      uhd::usrp::multi_usrp::sptr usrp, -    const std::vector<result_t> &results, -    const std::string &XX, -    const std::string &xx, -    const std::string &what +    const std::string &tx_rx  ){ -    //extract eeprom serial      uhd::property_tree::sptr tree = usrp->get_device()->get_tree(); -    const uhd::fs_path db_path = "/mboards/0/dboards/A/" + xx + "_eeprom"; +    uhd::usrp::subdev_spec_t subdev_spec = usrp->get_rx_subdev_spec(); +    const uhd::fs_path db_path = "/mboards/0/dboards/" + subdev_spec[0].db_name + "/" + tx_rx + "_eeprom";      const uhd::usrp::dboard_eeprom_t db_eeprom = tree->access<uhd::usrp::dboard_eeprom_t>(db_path).get(); +    return db_eeprom.serial; +} +/*********************************************************************** + * Store data to file + **********************************************************************/ +static void store_results( +    const std::vector<result_t> &results, +    const std::string &XX, // "TX" or "RX" +    const std::string &xx, // "tx" or "rx" +    const std::string &what, // Type of test, e.g. "iq", +    const std::string &serial +){      //make the calibration file path      fs::path cal_data_path = fs::path(uhd::get_app_path()) / ".uhd";      fs::create_directory(cal_data_path);      cal_data_path = cal_data_path / "cal";      fs::create_directory(cal_data_path); -    cal_data_path = cal_data_path / str(boost::format("%s_%s_cal_v0.2_%s.csv") % xx % what % db_eeprom.serial); +    cal_data_path = cal_data_path / str(boost::format("%s_%s_cal_v0.2_%s.csv") % xx % what % serial);      if (fs::exists(cal_data_path)){          fs::rename(cal_data_path, cal_data_path.string() + str(boost::format(".%d") % time(NULL)));      } @@ -207,7 +217,7 @@ static void store_results(      //fill the calibration file      std::ofstream cal_data(cal_data_path.string().c_str());      cal_data << boost::format("name, %s Frontend Calibration\n") % XX; -    cal_data << boost::format("serial, %s\n") % db_eeprom.serial; +    cal_data << boost::format("serial, %s\n") % serial;      cal_data << boost::format("timestamp, %d\n") % time(NULL);      cal_data << boost::format("version, 0, 1\n");      cal_data << boost::format("DATA STARTS HERE\n"); @@ -259,3 +269,4 @@ static void capture_samples(          throw std::runtime_error("did not get all the samples requested");      }  } + | 
